proposal: review meeting minutes #33502

Open

Open

proposal: review meeting minutes#33502

Labels

Proposalumbrella

Milestone

Contributor

The proposal review group meets regularly (roughly weekly) to review pending proposal issues and move them along in the proposal process.

Review consists primarily of checking that discussion is ongoing, commenting on issues to move discussion along, summarizing long discussions, CC’ing experts, and accepting or closing proposals when the discussion on the GitHub issue has reached a clear consensus about the outcome.

Review also includes closing proposals that are untenable (for example, because the changes are backwards-incompatible or violate key design goals of the language or packages).

This meta-issue records minutes of the proposal review meetings as issue comments, so that they can be cross-linked easily with the relevant issues. (This meta-issue is for minutes only; comments that are not meeting minutes will be deleted.)

locked and limited conversation to collaborators

changed the title ~~[-]placeholder[/-]~~ proposal: review meeting minutes

added this to the Proposal milestone

added

ContributorAuthor

2019-08-06 / @rsc, @griesemer, @andybons

cmd/fix: automate migrations for simple deprecations #32816 cmd/fix: automate migrations for simple deprecations
- discussion ongoing (no action taken)
proposal: cmd/go: add build tags for 32-bit and 64-bit architectures #33388 cmd/go: add build tags for 32-bit and 64-bit architectures
- retitled, commented
proposal: cmd/go: add package search functionality #33203 cmd/go: add package search functionality
- commented
proposal: cmd/go: automatic and partial vendoring in module mode #30240 cmd/go: automatic vendoring in module mode
- discussion ongoing
proposal: cmd/go: introduce go.gen file for //go:generate comments #33375 cmd/go: introduce go.gen file for //go:generate comments
- commented
proposal: crypto: add crypto engines #33281 crypto engines
- labeled Proposal-Crypto; discussion ongoing
crypto: implement Hash.String #33430 crypto: crypto.Hash implement fmt.Stringer and export crypto.maxHash
- labeled Proposal-Crypto, commented
encoding/json: memoize strings during decode #32779 encoding/json: memoize strings during decode?
- commented, commented on CL
proposal: errors: generalize As to all types #33473 errors: generalize As to all types
- retitled, commented
proposal: image: add generic metadata support for jpeg, gif, png #33457 image: add generic metadata support for jpeg, gif, png
- retitled, cc’ed expert
proposal: log: modify Logger struct, make it supports multi output #33454 log: modify `Logger` struct, make it supports multi output
- closed (backwards-incompatible change; easy implementation outside standard library; no evidence of widespread need)
proposal: net/url: add (Values).AddAll(key string, values []string) #33498 net/url: add (Values).AddAll(key string, values []string)
- retitled, commented
sizeof: new package with constants for Int, Uint, Uintptr, Int8, Float64, etc #29982 reflect: add constants for size of int, bool, etc.
- summarized
proposal: text/template: make "template" action accept dynamic name as argument #33449 text/template: make "template" action accept dynamic name as argument
- commented, cc’ed expert
proposal: x/tools: tool to audit diffs in dependencies #33466 x/tools: tool to audit diffs in dependencies
- discussion ongoing
proposal: x/tools/cmd/gopls: provide config option for hover documentation placement #33352 x/tools/cmd/gopls: provide config option for hover documentation placement
- discussion ongoing

Member

2019-08-13 / @rsc, @griesemer, @andybons, @spf13

proposal: cmd/go: secure releases with transparency log #25530 cmd/go: secure releases with transparency log
- commented
- likely accept; last call for comments
proposal: errors: simplified error inspection #32405 errors: simplified error inspection
- commented
- likely decline; last call for comments
proposal: net/http: add constant for content type #31572 net/http: add constant for content type
- commented
- likely decline; last call for comments
proposal: net/url: add FromFilePath and ToFilePath #32456 net/url: add FromFilePath and ToFilePath
- asked for design doc
- put on hold for design doc
proposal: runtime: add way for applications to respond to GC backpressure #29696 runtime: add way for applications to respond to GC backpressure
- asked owners for status
proposal: runtime: KeepAlive should perhaps keep things from being moved #32115 runtime: KeepAlive should perhaps keep things from being moved
- asked owners for feedback
proposal: text/template: allow io.Reader as substitution value #29165 text/template: allow io.Reader as substitution value
- suggested design doc
proposal: x/net/nettest: add MakeLocalPipe to construct local listener and connections #30984 x/net/nettest: add MakeLocalPipe to construct local listener and connections
- commented
- pinged owners of package

Member

2019-08-20 / @rsc, @griesemer, @andybons, @ianlancetaylor

Proposal: deterministic execution #33702 deterministic execution
- closed (no concrete change to evaluate)
proposal: cmd/go: secure releases with transparency log #25530 cmd/go: secure releases with transparency log
- no final comments; accepted 🎉
proposal: cmd/go: add build tags for 32-bit and 64-bit architectures #33388 cmd/go: add build tags for 32-bit and 64-bit architectures
- commented
proposal: cmd/go: add package search functionality #33203 cmd/go: add package search functionality
- commented
proposal: cmd/go: introduce go.gen file for //go:generate comments #33375 cmd/go: introduce go.gen file for //go:generate comments
- commented
- likely decline; last call for comments
proposal: errors: simplified error inspection #32405 errors: simplified error inspection
- no final comments; declined
proposal: net/http: add constant for content type #31572 net/http: add constant for content type
- no final comments; declined
proposal: net/url: add (Values).AddAll(key string, values []string) #33498 net/url: add (Values).AddAll(key string, values []string)
- commented
- likely decline; last call for comments
proposal: identify large changes & add more process #33670 proposal: identify large changes & add more process
- discussion ongoing
reflect: optimize v.Set(reflect.Zero(v.Type())) to not allocate #33136 reflect: add Value.SetZero
- commented
x/sys/cpu: add support for ARM #33508 x/sys/cpu -- add support for ARM
- commented
- asked owners for feedback
x/sys/unix: standardize Kevent_t Udata as integer, not pointer #32153 x/sys/unix: support for all fields of Kevent_t, EpollEvent
- commented
- reduced scope
- retitled

Member

2019-08-27 / @rsc, @bradfitz, @spf13, @andybons, @griesemer, @ianlancetaylor

proposal: cmd/go: add build tags for 32-bit and 64-bit architectures #33388 cmd/go: add build tags for 32-bit and 64-bit architectures
- commented
- likely decline; last call for comments
proposal: cmd/go: introduce go.gen file for //go:generate comments #33375 cmd/go: introduce go.gen file for //go:generate comments
- no final comments; declined
proposal: net: add ability to read OOB data without discarding a byte #32465 net: add ability to read OOB data without discarding a byte
- commented
- likely decline; last call for comments
proposal: net/url: add (Values).AddAll(key string, values []string) #33498 net/url: add (Values).AddAll(key string, values []string)
- no final comments; declined
Proposal: net/url: add Values.Decode #32634 net/url: add Values.Decode
- commented
proposal: os: add Touch to set access/mod times to current time #31880 os: add Touch to set access/mod times to current time
- commented
- likely decline; last call for comments
os: allow Chtimes with time.Time{} to avoid setting time #32558 os: allow Chtimes with time.Time{} to avoid setting time
- commented
reflect: optimize v.Set(reflect.Zero(v.Type())) to not allocate #33136 reflect: add Value.SetZero
- discussion ongoing
proposal: strings: a string factory to convert bytes to string #32593 strings: a string factory to convert bytes to string
- commented
- likely decline; last call for comments
x/sys/cpu: add support for ARM #33508 x/sys/cpu -- add support for ARM
- retitled
- commented
- likely accept; last call for comments
x/sys/unix: standardize Kevent_t Udata as integer, not pointer #32153 x/sys/unix: standardize Kevent_t Udata as integer, not pointer
- commented
- likely accept; last call for comments

Contributor

2019-09-03 / @bradfitz, @griesemer, @ianlancetaylor, @spf13

proposal: cmd/go: add build tags for 32-bit and 64-bit architectures #33388 cmd/go: add build tags for 32-bit and 64-bit architectures
- declined (no final comments)
proposal: net: add ability to read OOB data without discarding a byte #32465 net: add ability to read OOB data without discarding a byte
- declined (no final comments)
proposal: os: add Touch to set access/mod times to current time #31880 os: add Touch to set access/mod times to current time
- declined (no final comments)
proposal: strings: a string factory to convert bytes to string #32593 strings: a string factory to convert bytes to string
- declined (no final comments)
x/sys/cpu: add support for ARM #33508 x/sys/cpu: add support for ARM
- accepted (taking additional comments into account)
x/sys/unix: standardize Kevent_t Udata as integer, not pointer #32153 x/sys/unix: standardize Kevent_t Udata as integer, not pointer
- accepted (no additional comments)
move mature wiki content behind Gerrit #34038 move mature wiki content behind Gerrit
- commented, waiting for doc, x/tools/cmd/godoc, x/website: move golang.org content into its own repository #29206 (referenced)
proposal: os: make the internal lockedfile package public #33974 make the internal filelock package public
- cc: @bcmills
io/ioutil: reject path separators in TempDir, TempFile pattern #33920 io/ioutil: TempFile: pattern should prevent directory traversal
- commented, discussion ongoing
proposal: add standard library package for sizes #33459 add standard library package for sizes
- commented
Proposal: net/url: add Values.Decode #32634 net/url: add Values.Decode
- @bradfitz commented
io/ioutil: TempDir should support patterns like TempFile does #33805 io/ioutil: TempDir should support patterns like TempFile does
- commented (asking for feedback on proposed approach)
runtime: make GOMAXPROCS cfs-aware on GOOS=linux #33803 make GOMAXPROCS cfs-aware on GOOS=linux
- changed from proposal to feature request
doc: restructure module documentation #33637 doc: restructure module documentation
- commented (request for feedback)
text/template: make "eq" support all comparable types #33740 text/template: make "eq" support all comparable types
- cc: robpike

Member

2019-09-12 / @rsc, @bradfitz, @andybons, @griesemer, @ianlancetaylor

proposal: add standard library package for sizes #33459 add standard library package for sizes
- commented
proposal: cmd/go: allow 'go get -u' to upgrade the targets of replacements #32721 cmd/go: allow 'go get -u' to upgrade the targets of replacements
- cc’d domain experts
proposal: cmd/go: ignore +incompatible versions as of Go 1.14 #34217 cmd/go: ignore +incompatible versions as of Go 1.14
- discussion ongoing
proposal: encoding/pem: add DecodeStrict #34069 encoding/pem: add DecodeStrict
- commented
- cc’d domain experts
move mature wiki content behind Gerrit #34038 move mature wiki content behind Gerrit
- discussion ongoing
proposal: runtime/pprof: add new WithLabels* function that requires fewer allocations #33701 runtime/pprof: add new WithLabels* function that requires fewer allocations
- summarized
- cc’d domain experts
proposal: strconv: add a version of QuoteToASCII that doesn't add quotes #34145 strconv: add a version of QuoteToASCII that doesn't add quotes
- commented
sync: add new Map method LoadAndDelete #33762 sync: Map should provide DeleteWithLoad which returns loaded value and boolean
- discussion ongoing
testing: TestMain should not require os.Exit #34129 TestMain should not require os.Exit
- commented
- cc’d domain experts
testing: add Cleanup method #32111 testing: add Defer method
- commented
- cc’d more domain experts
text/template: make "eq" support all comparable types #33740 text/template: make "eq" support all comparable types
- commented
- likely accept; last call for comments
Proposal: net/url: add Values.Decode #32634 net/url: add Values.Decode
- commented
- likely decline; last call for comments

Member

2019-09-18 / @rsc, @bradfitz, @andybons, @griesemer, @ianlancetaylor, @spf13

proposal: context: enable first class citizenship of third party implementations #28728 context: enable first class citizenship of third party implementations
- summarized
- suggested a way to avoid an API change
- asked for comments
Proposal: net/url: add Values.Decode #32634 net/url: add Values.Decode
- no final comments; declined
proposal: os: Create/Open/OpenFile() set FILE_SHARE_DELETE on windows #32088 syscall: windows Open() should set FILE_SHARE_DELETE
- summarized
- asked for comments
text/template: make "eq" support all comparable types #33740 text/template: make "eq" support all comparable types
- no final comments; accepted 🎉

Member

2019-09-25 / @rsc, @bradfitz, @sfrancia, @andybons

proposal: cmd/go: ignore +incompatible versions as of Go 1.14 #34217 cmd/go: ignore +incompatible versions as of Go 1.14
- discussion ongoing
proposal: cmd/go: allow 'go get -u' to upgrade the targets of replacements #32721 cmd/go: allow 'go get -u' to upgrade the targets of replacements
- discussion ongoing
proposal: context: enable first class citizenship of third party implementations #28728 context: enable first class citizenship of third party implementations
- commented
proposal: encoding/pem: add DecodeStrict #34069 encoding/pem: add DecodeStrict
- commented
io/ioutil: TempDir should support patterns like TempFile does #33805 io/ioutil: TempDir should support patterns like TempFile does
- commented
- likely accept; last call for comments
net: make Resolver.PreferGo and GODEBUG=netdns=go use Go code on Windows #33097 net: Enable built-in DNS stub resolver on Windows
- asked for more information
- cc’d domain experts
proposal: net: add BufferedPipe (buffered Pipe) #34502 net: in-memory transport
- commented
proposal: os: Create/Open/OpenFile() set FILE_SHARE_DELETE on windows #32088 os: Create/Open/OpenFile() set FILE_SHARE_DELETE on windows
- commented
proposal: runtime/pprof: add new WithLabels* function that requires fewer allocations #33701 runtime/pprof: add new WithLabels* function that requires fewer allocations
- discussion ongoing
- cc’d domain experts
proposal: strconv: add a version of QuoteToASCII that doesn't add quotes #34145 strconv: add a version of QuoteToASCII that doesn't add quotes
- commented
- likely decline; last call for comments
sync: add new Map method LoadAndDelete #33762 sync: Map should provide DeleteWithLoad which returns loaded value and boolean
- commented
testing: add -shuffle and -shuffleseed to shuffle tests #28592 testing: let TestMain access and change the list of tests
- commented
testing: add Cleanup method #32111 testing: add Defer method
- cc’d domain experts
proposal: testing: add B.Lap for phases of benchmarks #33194 testing: (*B).Lap(string name, b *testing.B) for sub-benchmarks of a single process
- cc’d domain experts
testing: TestMain should not require os.Exit #34129 testing: TestMain should not require os.Exit
- cc’d domain experts
proposal: testing: automatically scale benchmark metrics in results output #33328 testing: automatically scale benchmark metrics in results output
- cc’d domain expert
proposal: x/tools/goimports: Look for .goimportsignore in modules #32928 x/tools/goimports: Look for .goimportsignore in modules
- commented
- cc’d domain owner
proposal for better string formatting #34523 proposal for better string formatting
- closed as duplicate of proposal: Go 2: string interpolation #34174
add "Backlog" milestone #34376 add "Backlog" milestone
- discussion ongoing
move mature wiki content behind Gerrit #34038 move mature wiki content behind Gerrit
- discussion ongoing
proposal: os: make the internal lockedfile package public #33974 make the internal filelock package public
- commented
- likely decline; last call for comments
proposal: add standard library package for sizes #33459 add standard library package for sizes
- commented
- likely decline; last call for comments
proposal: assert of errors #32997 assert of errors
- declined; error syntax handling is not changing
proposal: errors/errd: helper package for deferred error handlers #32676 errors/errd: helper package for deferred error handlers
- declined; author withdrew the proposal
proposal: doc: more overview of Go repo for new contributors #32741 doc: more overview of Go repo for new contributors
- commented

Member

2019-10-02 / @rsc, @bradfitz, @ianlancetaylor, @andybons

proposal: cmd/go: ignore directories containing .goignore in file scans #30058 cmd/doc: improve performance by excluding node_modules
- commented
- retitled
cmd/go: automatically check and use vendored packages #33848 cmd/go: automatically check and use vendored packages
- commented
- likely accept; last call for comments
proposal: context: enable first class citizenship of third party implementations #28728 context: enable first class citizenship of third party implementations
- commented
- likely decline; last call for comments
proposal: encoding/pem: add DecodeStrict #34069 encoding/pem: add DecodeStrict
- commented
- likely decline; last call for comments
io/ioutil: TempDir should support patterns like TempFile does #33805 io/ioutil: TempDir should support patterns like TempFile does
- no final comments; accepted 🎉
proposal: net: add BufferedPipe (buffered Pipe) #34502 net: in-memory transport
- commented
net: make Resolver.PreferGo and GODEBUG=netdns=go use Go code on Windows #33097 net: Enable built-in DNS stub resolver on Windows
- retitled
- commented
- likely accept; last call for comments
proposal: os: Create/Open/OpenFile() set FILE_SHARE_DELETE on windows #32088 os: Create/Open/OpenFile() set FILE_SHARE_DELETE on windows
- commented
- likely decline; last call for comments
proposal: runtime/pprof: add new WithLabels* function that requires fewer allocations #33701 runtime/pprof: add new WithLabels* function that requires fewer allocations
- commented
proposal: strconv: add a version of QuoteToASCII that doesn't add quotes #34145 strconv: add a version of QuoteToASCII that doesn't add quotes
- no final comments; declined
sync: add new Map method LoadAndDelete #33762 sync: Map should provide DeleteWithLoad which returns loaded value and boolean
- retitled
- commented
- likely accept; last call for comments
testing: add -shuffle and -shuffleseed to shuffle tests #28592 testing: let TestMain access and change the list of tests
- commented
- retitled
- rescoped
- cc’d domain experts
testing: add Cleanup method #32111 testing: add Defer method
- commented
- retitled
testing: TestMain should not require os.Exit #34129 testing: TestMain should not require os.Exit
- commented
proposal: testing: automatically scale benchmark metrics in results output #33328 testing: automatically scale benchmark metrics in results output
- commented
- likely decline; last call for comments
proposal: x/tools/goimports: Look for .goimportsignore in modules #32928 x/tools/goimports: Look for .goimportsignore in modules
- marked as duplicate of proposal: cmd/go: ignore directories containing .goignore in file scans #30058
add "Backlog" milestone #34376 add "Backlog" milestone
- commented
- likely accept; last call for comments
proposal: os: make the internal lockedfile package public #33974 make the internal lockedfile package public
- commented
- asked for design doc
proposal: add standard library package for sizes #33459 add standard library package for sizes
- no final comments; declined
proposal: doc: more overview of Go repo for new contributors #32741 doc: more overview of Go repo for new contributors
- closed; no concrete proposal

Member

2019-10-09 / @andybons, @bradfitz, @griesemer, @ianlancetaylor, @rsc

Proposals

add "Backlog" milestone #34376 add "Backlog" milestone
- no final comments; accepted 🎉
cmd/go: automatically check and use vendored packages #33848 cmd/go: automatically check and use vendored packages
- no final comments; accepted 🎉
proposal: cmd/go: ignore directories containing .goignore in file scans #30058 cmd/go: ignore directories containing .goignore in file scans
- commented
- likely decline; last call for comments
proposal: context: enable first class citizenship of third party implementations #28728 context: enable first class citizenship of third party implementations
- no final comments; declined
proposal: create contribution guidelines for technical writers #33323 create contribution guidelines for technical writers
- commented
proposal: encoding/pem: add DecodeStrict #34069 encoding/pem: add DecodeStrict
- no final comments; declined
proposal: os: make the internal lockedfile package public #33974 make the internal lockedfile package public
- put on hold
proposal: issues: distinguish "blocks beta/rc" from "blocks final release" #33135 meta: add milestone(s) or labels for pre-release blockers
- commented
- put on hold
proposal: net: add BufferedPipe (buffered Pipe) #34502 net: in-memory transport
- retitled
- likely accept; last call for comments
net: make Resolver.PreferGo and GODEBUG=netdns=go use Go code on Windows #33097 net: make Resolver.PreferGo and GODEBUG=netdns=go use Go code on Windows
- no final comments; accepted 🎉
proposal: os: Create/Open/OpenFile() set FILE_SHARE_DELETE on windows #32088 os: Create/Open/OpenFile() set FILE_SHARE_DELETE on windows
- no clear consensus; declined
proposal: runtime/pprof: add new WithLabels* function that requires fewer allocations #33701 runtime/pprof: add new WithLabels* function that requires fewer allocations
- ping’d conversation
sync: add new Map method LoadAndDelete #33762 sync: add new Map method LoadAndDelete
- no final comments; accepted 🎉
proposal: syscall: define Windows O_ALLOW_DELETE for use in os.OpenFile #34681 syscall: define Windows O_ALLOW_DELETE for use in os.OpenFile
- commented
testing: add -shuffle and -shuffleseed to shuffle tests #28592 testing: add -shuffle and -shuffleseed to shuffle tests
- commented
testing: add Cleanup method #32111 testing: add Cleanup method
- commented
- likely accept; last call for comments
proposal: testing: automatically scale benchmark metrics in results output #33328 testing: automatically scale benchmark metrics in results output
- no final comments; declined
testing: TestMain should not require os.Exit #34129 TestMain should not require os.Exit
- commented
- likely accept; last call for comments
x/website: add dark (night) theme #34601 x/website: add dark (night) theme
- commented
- put on hold

Issues with NeedsDecision label

bytes/hash: rename to hash/maphash #34778 bytes/hash: unfortunate import path
- commented
net, os: Set*Deadline() expiration error should be unique, as .Timeout() is true for keepalive, etc #31449 net: document that Conn.Read/Write should return error that Is(context.DeadlineExceeded) for deadline exceeded
- commented
- retitled
- moved to Go1.15
proposal: unsafe: clarify unsafe.Pointer rules for package syscall #34684 unsafe: clarify unsafe.Pointer rules for package syscall
- commented
x/mobile: Remove gomobile dependency on gobind binary #34708 x/mobile: Remove gomobile dependency on gobind binary
- cc’d domain experts

Member

2019-10-16 / @andybons, @bradfitz, @griesemer, @ianlancetaylor

cmd/go: add GOINSECURE for insecure dependencies #32966 cmd/go: add GOINSECURE for insecure dependencies
- commented
- likely accept; last call for comments
proposal: cmd/go: be consistent about not giving tests direct access to the terminal #34877 cmd/go: be consistent about not giving tests direct access to the terminal
- discussion ongoing
proposal: cmd/go: ignore directories containing .goignore in file scans #30058 cmd/go: ignore directories containing .goignore in file scans
- commented
- left open for further discussion
x/mod: move cmd/go/internal/modfile into x/mod for go.mod parsing and formatting #34924 cmd/go/internal/modfile: Expose modfile parsing as importable module
- commented
- cc’d domain experts
proposal: spec: compile-time boolean assertions #34868 compile-time boolean assertions
- commented
proposal: encoding/binary: cache dataSize across invocations of Read and Write #34471 encoding/binary: cache dataSize across invocations of Read and Write
- commented
proposal: encoding/json: new MarshalAppender interface to make custom marshallers more efficient #34701 encoding/json: new MarshalAppender interface to make custom marshallers more efficient
- discussion ongoing
html/template: document ability to modify FuncMap after template parse by calling Funcs again #34680 html/template: add ability to combine/clone/rebind parsed html/template templates
- commented
- asked for clarification
proposal: net: add BufferedPipe (buffered Pipe) #34502 net: add BufferedPipe (buffered Pipe)
- UPDATE: final comment period extended as new title was not used in previous meeting notes
- likely accept; last call for comments
net/url: add URL.Redacted to return password-free string #34855 net/url: add URL.Mask() method that hides the password
- commented
proposal: os: add UserShell #34910 os: add UserShell
- commented
- asked for clarification
testing: add Cleanup method #32111 testing: add Cleanup method
- no objections aside from some naming comments; accepted 🎉

256 remaining items

Loading

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

Proposalumbrella

Type

No type

Projects

No projects

Milestone

ProposalNo due date

Relationships

None yet

Development

No branches or pull requests

Participants